Mailing-List: contact issues-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
Date: Thu, 11 May 2017 22:33:04 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@drill.apache.org
Message-ID: <JIRA.13069614.1494026563000.192588.1494541984301@Atlassian.JIRA>
In-Reply-To: <JIRA.13069614.1494026563000@Atlassian.JIRA>
References: <JIRA.13069614.1494026563000@Atlassian.JIRA> <JIRA.13069614.1494026563079@jira-lw-us.apache.org>
Subject: [jira] [Commented] (DRILL-5481) Allow Drill to persist profiles
 in-memory only with a max capacity
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 11 May 2017 22:33:10 -0000


    [ https://issues.apache.org/jira/browse/DRILL-5481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007312#comment-16007312 ] 

ASF GitHub Bot commented on DRILL-5481:
---------------------------------------

Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/827#discussion_r116116935
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/store/InMemoryPersistentStore.java ---
    @@ -15,28 +15,40 @@
      * See the License for the specific language governing permissions and
      * limitations under the License.
      */
    -package org.apache.drill.exec.testing.store;
    +package org.apache.drill.exec.store.sys.store;
     
     import java.util.Iterator;
     import java.util.Map;
     import java.util.concurrent.ConcurrentMap;
    +import java.util.concurrent.ConcurrentSkipListMap;
    +import java.util.concurrent.atomic.AtomicInteger;
     import java.util.concurrent.locks.ReadWriteLock;
     import java.util.concurrent.locks.ReentrantReadWriteLock;
     
    -import com.google.common.collect.Iterables;
    -import com.google.common.collect.Maps;
     import org.apache.drill.common.concurrent.AutoCloseableLock;
    +import org.apache.drill.exec.exception.StoreException;
     import org.apache.drill.exec.exception.VersionMismatchException;
     import org.apache.drill.exec.store.sys.BasePersistentStore;
     import org.apache.drill.exec.store.sys.PersistentStoreMode;
    -import org.apache.drill.exec.store.sys.store.DataChangeVersion;
     
    -public class NoWriteLocalStore<V> extends BasePersistentStore<V> {
    +import com.google.common.collect.Iterables;
    +
    +public class InMemoryPersistentStore<V> extends BasePersistentStore<V> {
    +  // private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(InMemoryPersistentStore.class);
    +
       private final ReadWriteLock readWriteLock = new ReentrantReadWriteLock();
       private final AutoCloseableLock readLock = new AutoCloseableLock(readWriteLock.readLock());
       private final AutoCloseableLock writeLock = new AutoCloseableLock(readWriteLock.writeLock());
    -  private final ConcurrentMap<String, V> store = Maps.newConcurrentMap();
    +  private ConcurrentMap<String, V> store;
       private int version = -1;
    +  private int maxCapacity;
    --- End diff --
    
    final, here and below


> Allow Drill to persist profiles in-memory only with a max capacity
> ------------------------------------------------------------------
>
>                 Key: DRILL-5481
>                 URL: https://issues.apache.org/jira/browse/DRILL-5481
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.10.0
>            Reporter: Kunal Khatua
>            Assignee: Kunal Khatua
>
> To allow for fast persistence of profiles on a temporary basis (i.e. till the life of the Drillbit), an existing test class {{org.apache.drill.exec.testing.store.NoWriteLocalStore.java}} was refactored to {{org.apache.drill.exec.store.sys.store.EphemeralPersistentStore}} and given the ability to maintain a max capacity.
> This should allow query profiles to be available for as long as the Drillbit process' lifespan.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)