Mailing-List: contact issues-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
Date: Sat, 27 May 2017 05:39:06 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@drill.apache.org
Message-ID: <JIRA.13068316.1493697798000.308255.1495863546277@Atlassian.JIRA>
In-Reply-To: <JIRA.13068316.1493697798000@Atlassian.JIRA>
References: <JIRA.13068316.1493697798000@Atlassian.JIRA> <JIRA.13068316.1493697798691@jira-lw-us.apache.org>
Subject: [jira] [Commented] (DRILL-5457) Support Spill to Disk for the Hash
 Aggregate Operator
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sat, 27 May 2017 05:39:14 -0000


    [ https://issues.apache.org/jira/browse/DRILL-5457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027242#comment-16027242 ] 

ASF GitHub Bot commented on DRILL-5457:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/822#discussion_r118811819
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java ---
    @@ -166,20 +252,23 @@ public BatchHolder() {
         }
     
         private boolean updateAggrValues(int incomingRowIdx, int idxWithinBatch) {
    -      updateAggrValuesInternal(incomingRowIdx, idxWithinBatch);
    +      try { updateAggrValuesInternal(incomingRowIdx, idxWithinBatch); }
    +      catch (SchemaChangeException sc) { throw new DrillRuntimeException(sc); }
           maxOccupiedIdx = Math.max(maxOccupiedIdx, idxWithinBatch);
           return true;
         }
     
         private void setup() {
    -      setupInterior(incoming, outgoing, aggrValuesContainer);
    +      try { setupInterior(incoming, outgoing, aggrValuesContainer); }
    +      catch (SchemaChangeException sc) { throw new DrillRuntimeException(sc);}
         }
     
         private void outputValues(IndexPointer outStartIdxHolder, IndexPointer outNumRecordsHolder) {
           outStartIdxHolder.value = batchOutputCount;
           outNumRecordsHolder.value = 0;
           for (int i = batchOutputCount; i <= maxOccupiedIdx; i++) {
    -        outputRecordValues(i, batchOutputCount);
    +        try { outputRecordValues(i, batchOutputCount); }
    +        catch (SchemaChangeException sc) { throw new DrillRuntimeException(sc);}
    --- End diff --
    
    `IllegalStateException`?


> Support Spill to Disk for the Hash Aggregate Operator
> -----------------------------------------------------
>
>                 Key: DRILL-5457
>                 URL: https://issues.apache.org/jira/browse/DRILL-5457
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Execution - Relational Operators
>    Affects Versions: 1.10.0
>            Reporter: Boaz Ben-Zvi
>            Assignee: Boaz Ben-Zvi
>             Fix For: 1.11.0
>
>
> Support gradual spilling memory to disk as the available memory gets too small to allow in memory work for the Hash Aggregate Operator.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)