Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9834A200C80 for ; Thu, 25 May 2017 19:15:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 96BCB160BCA; Thu, 25 May 2017 17:15:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DCB97160BB4 for ; Thu, 25 May 2017 19:15:08 +0200 (CEST) Received: (qmail 86486 invoked by uid 500); 25 May 2017 17:15:08 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 86477 invoked by uid 99); 25 May 2017 17:15:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 May 2017 17:15:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id BD1D1C0CEB for ; Thu, 25 May 2017 17:15:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.001 X-Spam-Level: X-Spam-Status: No, score=-100.001 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id fjr38pkscgYR for ; Thu, 25 May 2017 17:15:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 784C85FDBB for ; Thu, 25 May 2017 17:15:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 11D99E0D3C for ; Thu, 25 May 2017 17:15:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id A847021B59 for ; Thu, 25 May 2017 17:15:04 +0000 (UTC) Date: Thu, 25 May 2017 17:15:04 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DRILL-5356) Refactor Parquet Record Reader MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 25 May 2017 17:15:09 -0000 [ https://issues.apache.org/jira/browse/DRILL-5356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025045#comment-16025045 ] ASF GitHub Bot commented on DRILL-5356: --------------------------------------- Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/789 Thanks. I'll clean up the messy commits today. Not sure how it picked up the other six commits... > Refactor Parquet Record Reader > ------------------------------ > > Key: DRILL-5356 > URL: https://issues.apache.org/jira/browse/DRILL-5356 > Project: Apache Drill > Issue Type: Improvement > Affects Versions: 1.10.0, 1.11.0 > Reporter: Paul Rogers > Assignee: Paul Rogers > Priority: Minor > Labels: ready-to-commit > Fix For: 1.11.0 > > > The Parquet record reader class is a key part of Drill that has evolved over time to become somewhat hard to follow. > A number of us are working on Parquet-related tasks and find we have to spend an uncomfortable amount of time trying to understand the code. In particular, this writer needs to figure out how to convince the reader to provide higher-density record batches. > Rather than continue to decypher the complex code multiple times, this ticket requests to refactor the code to make it functionally identical, but structurally cleaner. The result will be faster time to value when working with this code. > This is a lower-priority change and will be coordinated with others working on this code base. This ticket is only for the record reader class itself; it does not include the various readers and writers that Parquet uses since another project is actively modifying those classes. -- This message was sent by Atlassian JIRA (v6.3.15#6346)