drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5504) Vector validator to diagnose offset vector issues
Date Thu, 18 May 2017 23:00:08 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016610#comment-16016610
] 

ASF GitHub Bot commented on DRILL-5504:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/832#discussion_r117359430
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ImplCreator.java
---
    @@ -69,9 +70,18 @@ public static RootExec getExec(FragmentContext context, FragmentRoot
root) throw
         Preconditions.checkNotNull(root);
         Preconditions.checkNotNull(context);
     
    -    if (AssertionUtil.isAssertionsEnabled()) {
    +    // Enable iterator (operator) validation if assertions are enabled (debug mode)
    +    // or if in production mode and the ENABLE_ITERATOR_VALIDATION option is set
    +    // to true.
    +
    +    boolean enableValidation = AssertionUtil.isAssertionsEnabled();
    +    if (! enableValidation) {
    +      enableValidation = context.getOptionSet().getOption(ExecConstants.ENABLE_ITERATOR_VALIDATOR);
    +    }
    +    if (enableValidation) {
    --- End diff --
    
    Fixed.


> Vector validator to diagnose offset vector issues
> -------------------------------------------------
>
>                 Key: DRILL-5504
>                 URL: https://issues.apache.org/jira/browse/DRILL-5504
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.10.0
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>            Priority: Minor
>             Fix For: 1.11.0
>
>
> DRILL-5470 describes a case in which an offset vector appears to have become corrupted,
yielding a bogus field-length value that is orders of magnitude larger than the vector that
contains the data.
> Debugging such cases is slow and tedious. To help, we propose to create a "vector validator"
that spins through vectors looking for problems.
> Then, to allow the validator to be used in the field, extend the "iterator validator
batch iterator" to optionally allow vector validation on each batch.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message