drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5481) Allow Drill to persist profiles in-memory only with a max capacity
Date Thu, 11 May 2017 22:33:04 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007315#comment-16007315

ASF GitHub Bot commented on DRILL-5481:

Github user sudheeshkatkam commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/store/InMemoryPersistentStore.java
    @@ -15,28 +15,40 @@
      * See the License for the specific language governing permissions and
      * limitations under the License.
    -package org.apache.drill.exec.testing.store;
    +package org.apache.drill.exec.store.sys.store;
     import java.util.Iterator;
     import java.util.Map;
     import java.util.concurrent.ConcurrentMap;
    +import java.util.concurrent.ConcurrentSkipListMap;
    +import java.util.concurrent.atomic.AtomicInteger;
     import java.util.concurrent.locks.ReadWriteLock;
     import java.util.concurrent.locks.ReentrantReadWriteLock;
    -import com.google.common.collect.Iterables;
    -import com.google.common.collect.Maps;
     import org.apache.drill.common.concurrent.AutoCloseableLock;
    +import org.apache.drill.exec.exception.StoreException;
     import org.apache.drill.exec.exception.VersionMismatchException;
     import org.apache.drill.exec.store.sys.BasePersistentStore;
     import org.apache.drill.exec.store.sys.PersistentStoreMode;
    -import org.apache.drill.exec.store.sys.store.DataChangeVersion;
    -public class NoWriteLocalStore<V> extends BasePersistentStore<V> {
    +import com.google.common.collect.Iterables;
    +public class InMemoryPersistentStore<V> extends BasePersistentStore<V> {
    +  // private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(InMemoryPersistentStore.class);
       private final ReadWriteLock readWriteLock = new ReentrantReadWriteLock();
       private final AutoCloseableLock readLock = new AutoCloseableLock(readWriteLock.readLock());
       private final AutoCloseableLock writeLock = new AutoCloseableLock(readWriteLock.writeLock());
    -  private final ConcurrentMap<String, V> store = Maps.newConcurrentMap();
    +  private ConcurrentMap<String, V> store;
    --- End diff --

> Allow Drill to persist profiles in-memory only with a max capacity
> ------------------------------------------------------------------
>                 Key: DRILL-5481
>                 URL: https://issues.apache.org/jira/browse/DRILL-5481
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.10.0
>            Reporter: Kunal Khatua
>            Assignee: Kunal Khatua
> To allow for fast persistence of profiles on a temporary basis (i.e. till the life of
the Drillbit), an existing test class {{org.apache.drill.exec.testing.store.NoWriteLocalStore.java}}
was refactored to {{org.apache.drill.exec.store.sys.store.EphemeralPersistentStore}} and given
the ability to maintain a max capacity.
> This should allow query profiles to be available for as long as the Drillbit process'

This message was sent by Atlassian JIRA

View raw message