drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5481) Allow Drill to persist profiles in-memory only with a max capacity
Date Tue, 09 May 2017 17:21:04 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003101#comment-16003101

ASF GitHub Bot commented on DRILL-5481:

Github user kkhatua commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/store/EphemeralPersistentStore.java
    @@ -93,6 +107,14 @@ public void put(final String key, final V value, final DataChangeVersion
             throw new VersionMismatchException("Version mismatch detected", dataChangeVersion.getVersion());
           store.put(key, value);
    +      currentSize.incrementAndGet();
    +      if (currentSize.get() > maxCapacity) {
    +        //Pop Out Oldest
    +        ((ConcurrentSkipListMap<String, V>) store).pollLastEntry();
    --- End diff --
    The natural ordering of the profiles actually has the 'smallest' key being the latest.
Hence, we pop out the oldest entry by getting the 'largest'/last entry

> Allow Drill to persist profiles in-memory only with a max capacity
> ------------------------------------------------------------------
>                 Key: DRILL-5481
>                 URL: https://issues.apache.org/jira/browse/DRILL-5481
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.10.0
>            Reporter: Kunal Khatua
>            Assignee: Kunal Khatua
> To allow for fast persistence of profiles on a temporary basis (i.e. till the life of
the Drillbit), an existing test class {{org.apache.drill.exec.testing.store.NoWriteLocalStore.java}}
was refactored to {{org.apache.drill.exec.store.sys.store.EphemeralPersistentStore}} and given
the ability to maintain a max capacity.
> This should allow query profiles to be available for as long as the Drillbit process'

This message was sent by Atlassian JIRA

View raw message