drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5481) Allow Drill to persist profiles in-memory only with a max capacity
Date Tue, 09 May 2017 17:07:04 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003064#comment-16003064

ASF GitHub Bot commented on DRILL-5481:

Github user ppadma commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/store/provider/LocalPersistentStoreProvider.java
    @@ -57,14 +59,14 @@ public LocalPersistentStoreProvider(final DrillConfig config) throws
    -  public <V> PersistentStore<V> getOrCreateStore(PersistentStoreConfig<V>
storeConfig) {
    +  public <V> PersistentStore<V> getOrCreateStore(PersistentStoreConfig<V>
storeConfig) throws StoreException {
         case BLOB_PERSISTENT:
         case PERSISTENT:
    -      if (enableWrite) {
    +      if (!useEphemeral) {
    --- End diff --
    yes, ephemeral write should be false by default. For backward compatibility, we should
probably just stick with local write i.e. trigger ephemeral write when local write is false.

> Allow Drill to persist profiles in-memory only with a max capacity
> ------------------------------------------------------------------
>                 Key: DRILL-5481
>                 URL: https://issues.apache.org/jira/browse/DRILL-5481
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.10.0
>            Reporter: Kunal Khatua
>            Assignee: Kunal Khatua
> To allow for fast persistence of profiles on a temporary basis (i.e. till the life of
the Drillbit), an existing test class {{org.apache.drill.exec.testing.store.NoWriteLocalStore.java}}
was refactored to {{org.apache.drill.exec.store.sys.store.EphemeralPersistentStore}} and given
the ability to maintain a max capacity.
> This should allow query profiles to be available for as long as the Drillbit process'

This message was sent by Atlassian JIRA

View raw message