drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5459) Extend physical operator test framework to test mini plans consisting of multiple operators
Date Tue, 02 May 2017 06:32:04 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15992401#comment-15992401
] 

ASF GitHub Bot commented on DRILL-5459:
---------------------------------------

GitHub user jinfengni opened a pull request:

    https://github.com/apache/drill/pull/823

    DRILL-5459: Extend physical operator test framework to test mini plan…

    …s consisting of multiple operators.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jinfengni/incubator-drill DRILL-5459

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/823.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #823
    
----
commit 100d78791d7a10c5b791c4cc660a57b1d9f3a0d3
Author: Jinfeng Ni <jni@apache.org>
Date:   2017-04-22T00:34:15Z

    DRILL-5459: Extend physical operator test framework to test mini plans consisting of multiple
operators.

----


> Extend physical operator test framework to test mini plans consisting of multiple operators
> -------------------------------------------------------------------------------------------
>
>                 Key: DRILL-5459
>                 URL: https://issues.apache.org/jira/browse/DRILL-5459
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Tools, Build & Test
>            Reporter: Jinfeng Ni
>            Assignee: Jinfeng Ni
>
> DRILL-4437 introduced a unit test framework to test a non-scan physical operator. A JSON
reader is implicitly used to specify the inputs to the physical operator under test. 
> There are needs to extend such unit test framework for two scenarios.
> 1. We need a way to test scan operator with different record readers. Drill supports
a variety of data source, and it's important to make sure every record reader work properly
according to the protocol defined.
> 2. We need a way to test a so-called mini-plan (aka plan fragment) consisting of multiple
non-scan operators. 
> For the 2nd need, an alternative is to leverage SQL statement and query planner. However,
such approach has a direct dependency on query planner; 1) any planner change may impact the
testcase and lead to a different plan, 2) it's not always easy job to force the planner to
get a desired plan fragment for testing.
> In particular, it would be good to have a relatively easy way to specify a mini-plan
with a couple of targeted physical operators. 
> This JIRA is created to track the work to extend the unit test framework in DRILL-4437.
>  
> Related work: DRILL-5318 introduced a sub-operator test fixture, which mainly targeted
to test at sub-operator level. The framework in DRILL-4437 and the extension would focus on
operator level, or multiple operator levels, where execution would go through RecordBatch's
API call. 
> Same as DRILL-4437, we are going to use mockit to mock required objects such fragment
context, operator context etc. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message