drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5457) Support Spill to Disk for the Hash Aggregate Operator
Date Wed, 31 May 2017 00:12:04 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030402#comment-16030402
] 

ASF GitHub Bot commented on DRILL-5457:
---------------------------------------

Github user Ben-Zvi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/822#discussion_r119245339
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
---
    @@ -166,20 +252,23 @@ public BatchHolder() {
         }
     
         private boolean updateAggrValues(int incomingRowIdx, int idxWithinBatch) {
    -      updateAggrValuesInternal(incomingRowIdx, idxWithinBatch);
    +      try { updateAggrValuesInternal(incomingRowIdx, idxWithinBatch); }
    +      catch (SchemaChangeException sc) { throw new DrillRuntimeException(sc); }
           maxOccupiedIdx = Math.max(maxOccupiedIdx, idxWithinBatch);
           return true;
         }
     
         private void setup() {
    -      setupInterior(incoming, outgoing, aggrValuesContainer);
    +      try { setupInterior(incoming, outgoing, aggrValuesContainer); }
    +      catch (SchemaChangeException sc) { throw new DrillRuntimeException(sc);}
         }
     
         private void outputValues(IndexPointer outStartIdxHolder, IndexPointer outNumRecordsHolder)
{
           outStartIdxHolder.value = batchOutputCount;
           outNumRecordsHolder.value = 0;
           for (int i = batchOutputCount; i <= maxOccupiedIdx; i++) {
    -        outputRecordValues(i, batchOutputCount);
    +        try { outputRecordValues(i, batchOutputCount); }
    +        catch (SchemaChangeException sc) { throw new DrillRuntimeException(sc);}
    --- End diff --
    
    Done !



> Support Spill to Disk for the Hash Aggregate Operator
> -----------------------------------------------------
>
>                 Key: DRILL-5457
>                 URL: https://issues.apache.org/jira/browse/DRILL-5457
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Execution - Relational Operators
>    Affects Versions: 1.10.0
>            Reporter: Boaz Ben-Zvi
>            Assignee: Boaz Ben-Zvi
>             Fix For: 1.11.0
>
>
> Support gradual spilling memory to disk as the available memory gets too small to allow
in memory work for the Hash Aggregate Operator.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message