drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5457) Support Spill to Disk for the Hash Aggregate Operator
Date Wed, 24 May 2017 02:47:04 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022238#comment-16022238
] 

ASF GitHub Bot commented on DRILL-5457:
---------------------------------------

Github user Ben-Zvi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/822#discussion_r118152042
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractBase.java
---
    @@ -99,17 +100,31 @@ public void setCost(double cost) {
         this.cost = cost;
       }
     
    -  // Not available. Presumably because Drill does not currently use
    -  // this value, though it does appear in some test physical plans.
    -//  public void setMaxAllocation(long alloc) {
    -//    maxAllocation = alloc;
    -//  }
    -
       @Override
       public long getMaxAllocation() {
         return maxAllocation;
       }
     
    +  /**
    +   * Any operator that supports spilling should override this method
    +   * @param maxAllocation The max memory allocation to be set
    +   */
    +  @Override
    +  public void setMaxAllocation(long maxAllocation) {
    +    this.maxAllocation = maxAllocation;
    +    /*throw new DrillRuntimeException("Unsupported method: setMaxAllocation()");*/
    +  }
    +
    +  /**
    +   * Any operator that supports spilling should override this method (and return true)
    +   * @return false
    +   */
    +  @Override
    +  public boolean getBufferedOperator() { return false; }
    --- End diff --
    
    Changes made ...



> Support Spill to Disk for the Hash Aggregate Operator
> -----------------------------------------------------
>
>                 Key: DRILL-5457
>                 URL: https://issues.apache.org/jira/browse/DRILL-5457
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Execution - Relational Operators
>    Affects Versions: 1.10.0
>            Reporter: Boaz Ben-Zvi
>            Assignee: Boaz Ben-Zvi
>             Fix For: 1.11.0
>
>
> Support gradual spilling memory to disk as the available memory gets too small to allow
in memory work for the Hash Aggregate Operator.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message