drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5419) Calculate return string length for literals & some string functions
Date Mon, 01 May 2017 17:42:04 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991159#comment-15991159

ASF GitHub Bot commented on DRILL-5419:

Github user jinfengni commented on a diff in the pull request:

    --- Diff: common/src/main/java/org/apache/drill/common/types/Types.java ---
    @@ -636,43 +658,63 @@ public static String toString(final MajorType type) {
        * Get the <code>precision</code> of given type.
    -   * @param majorType
    -   * @return
    +   *
    +   * @param majorType major type
    +   * @return precision value
       public static int getPrecision(MajorType majorType) {
    -    MinorType type = majorType.getMinorType();
    -    if (type == MinorType.VARBINARY || type == MinorType.VARCHAR) {
    -      return 65536;
    -    }
         if (majorType.hasPrecision()) {
           return majorType.getPrecision();
    -    return 0;
    +    return isScalarStringType(majorType) ? MAX_VARCHAR_LENGTH : UNDEFINED;
    --- End diff --
    The way this PR calculates the maximum length is not from "guess". The metadata information
leveraged in this PR is in the "query" itself ( the function appearing in the query, or the
string literal in the query). It does not apply to all the queries; only when the query provides
enough information Drill will calculate the maximum length. In all other cases, Drill will
perform same as before.
    The maximum length (L1) calculated in this PR is different different from what you describe
in the case of scanner (L2).  L2 <= L1. In the example of scanner with no metadata available,
there would be no schema change; the precision is unset in type field, same as before. 
    @arina-ielchiieva can correct me if my understanding is wrong. 

> Calculate return string length for literals & some string functions
> -------------------------------------------------------------------
>                 Key: DRILL-5419
>                 URL: https://issues.apache.org/jira/browse/DRILL-5419
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.9.0
>            Reporter: Arina Ielchiieva
>            Assignee: Arina Ielchiieva
>         Attachments: version_with_cast.JPG
> Though Drill is schema-less and cannot determine in advance what the length of the column
should be but if query has an explicit type/length specified, Drill should return correct
column length.
> For example, JDBC / ODBC Driver is ALWAYS returning 64K as the length of a varchar or
char even if casts are applied.
> Changes:
> String literals length is the same as actual literal length.
> Example: for 'aaa' return length is 3.
> *CAST*
> Return length is the one indicated in cast expression. This also applies when user has
created view where each string columns was casted to varchar with some specific length.
> This length will be returned to the user without need to apply cast one more time. Below
mentioned functions can take leverage of underlying varchar length and calculate return length.
> Return length is underlying column length, i.e. if column is known, the same length will
be returned.
> Example:
> lower(cast(col as varchar(30))) will return 30.
> lower(col) will return max varchar length, since we don't know actual column length.
> Return length is underlying column length but column type will be nullable.
> Pads the string to the length specified. Return length is this specified length. 
> Return length is sum of underlying columns length. If length is greater then varchar
max length,  varchar max length is returned.
> Calculates return length according to each function substring rules, for example, taking
into account how many char should be substracted.
> When combining string columns with different length, return length is max from source

This message was sent by Atlassian JIRA

View raw message