drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5325) Implement sub-operator unit tests for managed external sort
Date Sat, 27 May 2017 01:23:05 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027102#comment-16027102

ASF GitHub Bot commented on DRILL-5325:

Github user Ben-Zvi commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java
    @@ -346,9 +346,7 @@ public IterOutcome innerNext() {
                   if (unionTypeEnabled) {
                     this.schema = SchemaUtil.mergeSchemas(schema, incoming.getSchema());
                   } else {
    -                throw SchemaChangeException.schemaChanged("Schema changes not supported
in External Sort. Please enable Union type",
    -                    schema,
    -                    incoming.getSchema());
    +                throw new SchemaChangeException("Schema changes not supported in External
Sort. Please enable Union type");
    --- End diff --
    Why remove the description of the previous/new schemas ? 

> Implement sub-operator unit tests for managed external sort
> -----------------------------------------------------------
>                 Key: DRILL-5325
>                 URL: https://issues.apache.org/jira/browse/DRILL-5325
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Tools, Build & Test
>    Affects Versions: 1.11.0
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>             Fix For: 1.11.0
> Validate the proposed sub-operator test framework, by creating low-level unit tests for
the managed version of the external sort.
> The external sort has a small number of existing tests, but those tests are quite superficial;
the "managed sort" project found many bugs. The managed sort itself was tested with ad-hoc
system-level tests created using the new "cluster fixture" framework. But, again, such tests
could not reach deep inside the sort code to exercise very specific conditions.
> As a result, we spent far too much time using QA functional tests to identify specific
code issues.
> Using the sub-opeator unit test framework, we can instead test each bit of functionality
at the unit test level.
> If doing so works, and is practical, it can serve as a model for other operator testing

This message was sent by Atlassian JIRA

View raw message