drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5325) Implement sub-operator unit tests for managed external sort
Date Sat, 27 May 2017 01:23:04 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027092#comment-16027092

ASF GitHub Bot commented on DRILL-5325:

Github user Ben-Zvi commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/SortMemoryManager.java
    @@ -0,0 +1,506 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.physical.impl.xsort.managed;
    +public class SortMemoryManager {
    --- End diff --
    Could this class be generalized for all spilling operators (and then customized for Sort,
e.g., merge related parts.) ?  There are some parts with "fuzzy math" (e.g. batch size estimates;
memory needed) ; Hash Agg is also doing its own fuzzy math - should all these be done the
same way ? 
    (The Hash Agg tried to be more conservative - like assuming 3 batches per a partition,
though in theory 2 would do; currently this is controlled with an option)

> Implement sub-operator unit tests for managed external sort
> -----------------------------------------------------------
>                 Key: DRILL-5325
>                 URL: https://issues.apache.org/jira/browse/DRILL-5325
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Tools, Build & Test
>    Affects Versions: 1.11.0
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>             Fix For: 1.11.0
> Validate the proposed sub-operator test framework, by creating low-level unit tests for
the managed version of the external sort.
> The external sort has a small number of existing tests, but those tests are quite superficial;
the "managed sort" project found many bugs. The managed sort itself was tested with ad-hoc
system-level tests created using the new "cluster fixture" framework. But, again, such tests
could not reach deep inside the sort code to exercise very specific conditions.
> As a result, we spent far too much time using QA functional tests to identify specific
code issues.
> Using the sub-opeator unit test framework, we can instead test each bit of functionality
at the unit test level.
> If doing so works, and is practical, it can serve as a model for other operator testing

This message was sent by Atlassian JIRA

View raw message