drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4335) Apache Drill should support network encryption
Date Fri, 05 May 2017 16:42:04 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15998548#comment-15998548
] 

ASF GitHub Bot commented on DRILL-4335:
---------------------------------------

Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/773#discussion_r115038537
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserClient.java
---
    @@ -201,10 +223,12 @@ protected SaslException mapException(Exception e) {
                 if (e instanceof ExecutionException) {
                   final Throwable cause = Throwables.getRootCause(e);
                   if (cause instanceof SaslException) {
    -                return new SaslException("Authentication failed: " + cause.getMessage(),
cause);
    +                return new SaslException(String.format("Authentication failed. [Details:
%s, Error %s]",
    +                    connection.getEncryptionCtxtString(), cause.getMessage()), cause);
                   }
                 }
    -            return new SaslException("Authentication failed unexpectedly.", e);
    +            return new SaslException(String.format("Authentication failed. [Details:
%s, Error %s",
    --- End diff --
    
    Two fixes: Authentication failed **unexpectedly.** [Details: %s, Error %s **]**


> Apache Drill should support network encryption
> ----------------------------------------------
>
>                 Key: DRILL-4335
>                 URL: https://issues.apache.org/jira/browse/DRILL-4335
>             Project: Apache Drill
>          Issue Type: New Feature
>            Reporter: Keys Botzum
>            Assignee: Sorabh Hamirwasia
>              Labels: security
>         Attachments: ApacheDrillEncryptionUsingSASLDesign.pdf
>
>
> This is clearly related to Drill-291 but wanted to make explicit that this needs to include
network level encryption and not just authentication. This is particularly important for the
client connection to Drill which will often be sending passwords in the clear until there
is encryption.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message