Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4E1B0200C67 for ; Mon, 17 Apr 2017 07:36:48 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 4C928160B9D; Mon, 17 Apr 2017 05:36:48 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 92E70160B9A for ; Mon, 17 Apr 2017 07:36:47 +0200 (CEST) Received: (qmail 5696 invoked by uid 500); 17 Apr 2017 05:36:46 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 5687 invoked by uid 99); 17 Apr 2017 05:36:45 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Apr 2017 05:36:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 4371CC25B9 for ; Mon, 17 Apr 2017 05:36:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id hiGtWcf5KNvE for ; Mon, 17 Apr 2017 05:36:44 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id EB5365F3DA for ; Mon, 17 Apr 2017 05:36:43 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 1850AE00A6 for ; Mon, 17 Apr 2017 05:36:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 646F821B46 for ; Mon, 17 Apr 2017 05:36:42 +0000 (UTC) Date: Mon, 17 Apr 2017 05:36:42 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DRILL-5324) Provide simplified column reader/writer for use in tests MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 17 Apr 2017 05:36:48 -0000 [ https://issues.apache.org/jira/browse/DRILL-5324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15970693#comment-15970693 ] ASF GitHub Bot commented on DRILL-5324: --------------------------------------- Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/783 Done. Also rebased on master. > Provide simplified column reader/writer for use in tests > -------------------------------------------------------- > > Key: DRILL-5324 > URL: https://issues.apache.org/jira/browse/DRILL-5324 > Project: Apache Drill > Issue Type: Sub-task > Components: Tools, Build & Test > Affects Versions: 1.11.0 > Reporter: Paul Rogers > Assignee: Paul Rogers > Labels: ready-to-commit > Fix For: 1.11.0 > > > In support of DRILL-5323, we wish to provide a very easy way to work with row sets. See the comment section for examples of the target API. > Drill provides over 100 different value vectors, any of which may be required to perform a specific unit test. Creating these vectors, populating them, and retrieving values, is very tedious. The work is so complex that it acts to discourage developers from writing such tests. > To simplify the task, we wish to provide a simplified row set reader and writer. To do that, we need to generate the corresponding column reader and writer for each value vector. This ticket focuses on the column-level readers and writers, and the required code generation. > Drill already provides vector readers and writers derived from {{FieldReader}}. However, these readers do not provide a uniform get/set interface that is type independent on the application side. Instead, application code must be aware of the type of the vector, something we seek to avoid for test code. > The reader and writer classes are designed to be used in many contexts, not just for testing. As a result, their implementation makes no assumptions about the broader row reader and writer, other than that a row index and the required value vector are both available. -- This message was sent by Atlassian JIRA (v6.3.15#6346)