Mailing-List: contact issues-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
Date: Wed, 26 Apr 2017 02:37:05 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@drill.apache.org
Message-ID: <JIRA.12935747.1454359820000.50997.1493174225411@Atlassian.JIRA>
In-Reply-To: <JIRA.12935747.1454359820000@Atlassian.JIRA>
References: <JIRA.12935747.1454359820000@Atlassian.JIRA> <JIRA.12935747.1454359820542@jira-lw-us.apache.org>
Subject: [jira] [Commented] (DRILL-4335) Apache Drill should support network
 encryption
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 26 Apr 2017 02:37:11 -0000


    [ https://issues.apache.org/jira/browse/DRILL-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15984048#comment-15984048 ] 

ASF GitHub Bot commented on DRILL-4335:
---------------------------------------

Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/773#discussion_r113245537
  
    --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/EncryptionContext.java ---
    @@ -0,0 +1,37 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.drill.exec.rpc;
    +
    +public interface EncryptionContext {
    --- End diff --
    
    Maybe rename to `EncryptionOptions` or `EncryptionSettings`? This also fits well with two implementations based on lifecycle: configured encryption options (immutable, defined in config classes) and connection encryption options (negotiated).
    
    And instead of connection interface implementing this interface, maybe have a `getEncryptionOptions` in the `RemoteConnection` interface. So the usage would be: `connection.getEncryptionOptions().isEnabled()` or `connection.getEncryptionOptions().getMaxWrappedSize()`.
    
    This is a variant of what you had previously. Sorry for the back and forth on this.


> Apache Drill should support network encryption
> ----------------------------------------------
>
>                 Key: DRILL-4335
>                 URL: https://issues.apache.org/jira/browse/DRILL-4335
>             Project: Apache Drill
>          Issue Type: New Feature
>            Reporter: Keys Botzum
>            Assignee: Sorabh Hamirwasia
>              Labels: security
>         Attachments: ApacheDrillEncryptionUsingSASLDesign.pdf
>
>
> This is clearly related to Drill-291 but wanted to make explicit that this needs to include network level encryption and not just authentication. This is particularly important for the client connection to Drill which will often be sending passwords in the clear until there is encryption.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)