drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5450) Fix initcap function to convert upper case characters correctly
Date Fri, 28 Apr 2017 10:39:04 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15988616#comment-15988616
] 

ASF GitHub Bot commented on DRILL-5450:
---------------------------------------

Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/821#discussion_r113900140
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctionHelpers.java
---
    @@ -169,7 +169,7 @@ public static void initCap(int start, int end, DrillBuf inBuf, DrillBuf
outBuf)
             if (currentByte >= 0x30 && currentByte <= 0x39) { // 0-9
               // noop
             } else if (currentByte >= 0x41 && currentByte <= 0x5A) { // A-Z
    -          currentByte -= 0x20; // Lowercase this character
    +          currentByte += 0x20; // Lowercase this character
    --- End diff --
    
    I did not notice any significant difference in performance, so will replace to `Character`
methods.


> Fix initcap function to convert upper case characters correctly
> ---------------------------------------------------------------
>
>                 Key: DRILL-5450
>                 URL: https://issues.apache.org/jira/browse/DRILL-5450
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Functions - Drill
>    Affects Versions: 1.10.0
>            Reporter: Arina Ielchiieva
>            Assignee: Arina Ielchiieva
>
> Initcap function converts incorrectly subsequent upper case characters after first character.
> {noformat}
> 0: jdbc:drill:zk=local> select initcap('aaa') from (values(1));
> +---------+
> | EXPR$0  |
> +---------+
> | Aaa     |
> +---------+
> 1 row selected (0.275 seconds)
> 0: jdbc:drill:zk=local> select initcap('AAA') from (values(1));
> +---------+
> | EXPR$0  |
> +---------+
> | A!!     |
> +---------+
> 1 row selected (0.27 seconds)
> 0: jdbc:drill:zk=local> select initcap('aAa') from (values(1));
> +---------+
> | EXPR$0  |
> +---------+
> | A!a     |
> +---------+
> 1 row selected (0.229 seconds)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message