drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5415) Improve Fixture Builder to configure client properties and keep collection type properties for server
Date Sat, 08 Apr 2017 07:05:41 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15961717#comment-15961717

ASF GitHub Bot commented on DRILL-5415:

Github user sohami commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/FixtureBuilder.java ---
    @@ -117,7 +122,27 @@ public FixtureBuilder configProperty(String key, Object value) {
         if (configProps == null) {
           configProps = defaultProps();
    -    configProps.put(key, value.toString());
    +    if(value instanceof Collection<?>) {
    --- End diff --

> Improve Fixture Builder to configure client properties and keep collection type properties
for server
> -----------------------------------------------------------------------------------------------------
>                 Key: DRILL-5415
>                 URL: https://issues.apache.org/jira/browse/DRILL-5415
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Tools, Build & Test
>    Affects Versions: 1.11.0
>            Reporter: Sorabh Hamirwasia
>            Assignee: Sorabh Hamirwasia
>            Priority: Minor
>             Fix For: 1.11.0
> There are 2 improvements which are made as part of this pull request.
> 1) The Fixture Builder framework converts all the config properties for Drillbit into
string type. But there are certain configurations for authentication (like auth.mechanism)
which are expected to be list type. Thus there will be failure during type check. Change to
keep collections type config value as is and insert those config value after string types
are inserted.
> 2) The Fixture Builder framework when builds it tries to apply any system options / session
options (if set) for which it creates a default client. Hence with  cluster enabled for authentication
this default client will not provide any connection parameters for authentication and will
fail to connect. Allow Fixture Builder to accept client related properties as well so that
can be used while creating default client to connect to cluster.

This message was sent by Atlassian JIRA

View raw message