drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5324) Provide simplified column reader/writer for use in tests
Date Fri, 14 Apr 2017 00:03:42 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15968422#comment-15968422

ASF GitHub Bot commented on DRILL-5324:

Github user bitblender commented on a diff in the pull request:

    --- Diff: exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/ScalarWriter.java
    @@ -0,0 +1,32 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.vector.accessor;
    +import java.math.BigDecimal;
    +import org.joda.time.Period;
    --- End diff --
    Adding a comment here saying that Writers use an implicit index would make it easier for
readers to understand why there is no index parameter and why the ScalarWriter interface can
be inherited-from by both the ColumnWriter and the ArrayWriter

> Provide simplified column reader/writer for use in tests
> --------------------------------------------------------
>                 Key: DRILL-5324
>                 URL: https://issues.apache.org/jira/browse/DRILL-5324
>             Project: Apache Drill
>          Issue Type: Sub-task
>          Components: Tools, Build & Test
>    Affects Versions: 1.11.0
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>             Fix For: 1.11.0
> In support of DRILL-5323, we wish to provide a very easy way to work with row sets. See
the comment section for examples of the target API.
> Drill provides over 100 different value vectors, any of which may be required to perform
a specific unit test. Creating these vectors, populating them, and retrieving values, is very
tedious. The work is so complex that it acts to discourage developers from writing such tests.
> To simplify the task, we wish to provide a simplified row set reader and writer. To do
that, we need to generate the corresponding column reader and writer for each value vector.
This ticket focuses on the column-level readers and writers, and the required code generation.
> Drill already provides vector readers and writers derived from {{FieldReader}}. However,
these readers do not provide a uniform get/set interface that is type independent on the application
side. Instead, application code must be aware of the type of the vector, something we seek
to avoid for test code.
> The reader and writer classes are designed to be used in many contexts, not just for
testing. As a result, their implementation makes no assumptions about the broader row reader
and writer, other than that a row index and the required value vector are both available.

This message was sent by Atlassian JIRA

View raw message