drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5323) Provide test tools to create, populate and compare row sets
Date Thu, 06 Apr 2017 00:17:42 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958081#comment-15958081
] 

ASF GitHub Bot commented on DRILL-5323:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/785#discussion_r110056124
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/RowSetWriterImpl.java
---
    @@ -0,0 +1,110 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.test.rowSet;
    +
    +import java.math.BigDecimal;
    +
    +import org.apache.drill.exec.vector.ValueVector;
    +import org.apache.drill.exec.vector.accessor.AbstractColumnWriter;
    +import org.apache.drill.exec.vector.accessor.ColumnAccessorFactory;
    +import org.apache.drill.exec.vector.accessor.ColumnWriter;
    +import org.apache.drill.test.rowSet.RowSet.RowSetWriter;
    +import org.joda.time.Period;
    +
    +/**
    + * Implements a row set writer on top of a {@link RowSet}
    + * container.
    + */
    +
    +public class RowSetWriterImpl extends AbstractRowSetAccessor implements RowSetWriter
{
    +
    +  private final AbstractColumnWriter writers[];
    +
    +  public RowSetWriterImpl(AbstractSingleRowSet recordSet, AbstractRowIndex rowIndex)
{
    +    super(rowIndex, recordSet.schema().access());
    +    ValueVector[] valueVectors = recordSet.vectors();
    +    writers = new AbstractColumnWriter[valueVectors.length];
    +    int posn = 0;
    +    for (int i = 0; i < writers.length; i++) {
    +      writers[posn] = ColumnAccessorFactory.newWriter(valueVectors[i].getField().getType());
    --- End diff --
    
    Fixed.


> Provide test tools to create, populate and compare row sets
> -----------------------------------------------------------
>
>                 Key: DRILL-5323
>                 URL: https://issues.apache.org/jira/browse/DRILL-5323
>             Project: Apache Drill
>          Issue Type: Sub-task
>          Components: Tools, Build & Test
>    Affects Versions: 1.11.0
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>             Fix For: 1.11.0
>
>
> Operators work with individual row sets. A row set is a collection of records stored
as column vectors. (Drill uses various terms for this concept. A record batch is a row set
with an operator implementation wrapped around it. A vector container is a row set, but with
much functionality left as an exercise for the developer. And so on.)
> To simplify tests, we need a {{TestRowSet}} concept that wraps a {{VectorContainer}}
and provides easy ways to:
> * Define a schema for the row set.
> * Create a set of vectors that implement the schema.
> * Populate the row set with test data via code.
> * Add an SV2 to the row set.
> * Pass the row set to operator components (such as generated code blocks.)
> * Compare the results of the operation with an expected result set.
> * Dispose of the underling direct memory when work is done.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message