drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5319) Refactor FragmentContext and OptionManager for unit testing
Date Thu, 06 Apr 2017 18:42:41 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959516#comment-15959516
] 

ASF GitHub Bot commented on DRILL-5319:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/787#discussion_r110232430
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentExecContext.java
---
    @@ -0,0 +1,49 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.ops;
    +
    +import java.io.IOException;
    +import java.util.List;
    +
    +import org.apache.drill.common.config.DrillConfig;
    +import org.apache.drill.exec.exception.ClassTransformationException;
    +import org.apache.drill.exec.expr.ClassGenerator;
    +import org.apache.drill.exec.expr.CodeGenerator;
    +import org.apache.drill.exec.expr.fn.FunctionImplementationRegistry;
    +import org.apache.drill.exec.server.options.OptionSet;
    +import org.apache.drill.exec.testing.ExecutionControls;
    +
    +public interface FragmentExecContext {
    +  FunctionImplementationRegistry getFunctionRegistry();
    +  OptionSet getOptionSet();
    +
    +  <T> T getImplementationClass(final ClassGenerator<T> cg)
    --- End diff --
    
    Was preserving the terseness of the original code, but sure, added comments.


> Refactor FragmentContext and OptionManager for unit testing
> -----------------------------------------------------------
>
>                 Key: DRILL-5319
>                 URL: https://issues.apache.org/jira/browse/DRILL-5319
>             Project: Apache Drill
>          Issue Type: Sub-task
>          Components: Tools, Build & Test
>    Affects Versions: 1.10.0
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>             Fix For: 1.11.0
>
>
> Roll-up task for two refactorings, see the sub-tasks for details. This ticket allows
a single PR for the two different refactorings since the work heavily overlaps. See DRILL-5320
and DRILL-5321 for details.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message