drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4335) Apache Drill should support network encryption
Date Wed, 26 Apr 2017 02:37:05 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15984052#comment-15984052
] 

ASF GitHub Bot commented on DRILL-4335:
---------------------------------------

Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/773#discussion_r112789119
  
    --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/AbstractRemoteConnection.java
---
    @@ -224,4 +240,104 @@ public void close() {
         }
       }
     
    +  /**
    +   * Helps to add all the required security handler's after negotiation for encryption
is completed.
    +   * <p>Handler's before encryption is negotiated are:</p>
    +   * <ul>
    +   *    <li>  PROTOCOL_DECODER {@link ProtobufLengthDecoder} </li>
    +   *    <li>  MESSAGE_DECODER {@link RpcDecoder}  </li>
    +   *    <li>  PROTOCOL_ENCODER {@link RpcEncoder} </li>
    +   *    <li>  HANDSHAKE_HANDLER {@link org.apache.drill.exec.rpc.BasicClient.ClientHandshakeHandler}
OR
    +   *                            {@link org.apache.drill.exec.rpc.BasicServer.ServerHandshakeHandler}
 </li>
    +   *    <li>  optional - IDLE_STATE_HANDLER {@link org.apache.drill.exec.rpc.BasicClient.IdlePingHandler}
OR
    +   *                   - TIMEOUT_HANDLER {@link org.apache.drill.exec.rpc.BasicServer.LoggingReadTimeoutHandler}
 </li>
    +   *    <li>  MESSAGE_HANDLER {@link org.apache.drill.exec.rpc.RpcBus.InboundHandler}
</li>
    +   *    <li>  EXCEPTION_HANDLER {@link RpcExceptionHandler} </li>
    +   * </ul>
    +   * <p>Handler's after encryption is negotiated are:</p>
    +   * <ul>
    +   *    <li>  LENGTH_DECODER_HANDLER {@link LengthFieldBasedFrameDecoder}
    +   *    <li>  SASL_DECRYPTION_HANDLER {@link SaslDecryptionHandler}
    +   *    <li>  PROTOCOL_DECODER {@link ProtobufLengthDecoder}
    +   *    <li>  MESSAGE_DECODER {@link RpcDecoder}
    +   *    <li>  SASL_ENCRYPTION_HANDLER {@link SaslEncryptionHandler}
    +   *    <li>  CHUNK_CREATION_HANDLER {@link ChunkCreationHandler}
    +   *    <li>  PROTOCOL_ENCODER {@link RpcEncoder}
    +   *    <li>  HANDSHAKE_HANDLER {@link org.apache.drill.exec.rpc.BasicClient.ClientHandshakeHandler}
OR
    +   *                            {@link org.apache.drill.exec.rpc.BasicServer.ServerHandshakeHandler}
    +   *    <li>  optional - IDLE_STATE_HANDLER {@link org.apache.drill.exec.rpc.BasicClient.IdlePingHandler}
OR
    +   *                   - TIMEOUT_HANDLER {@link org.apache.drill.exec.rpc.BasicServer.LoggingReadTimeoutHandler}
    +   *    <li>  MESSAGE_HANDLER {@link org.apache.drill.exec.rpc.RpcBus.InboundHandler}
    +   *    <li>  EXCEPTION_HANDLER {@link RpcExceptionHandler}
    +   * </ul>
    +   * <p>
    +   *  If encryption is enabled ChunkCreationHandler is always added to divide the Rpc
message into chunks of
    --- End diff --
    
    But does always adding the ChunckCreationHandler have performance implications?


> Apache Drill should support network encryption
> ----------------------------------------------
>
>                 Key: DRILL-4335
>                 URL: https://issues.apache.org/jira/browse/DRILL-4335
>             Project: Apache Drill
>          Issue Type: New Feature
>            Reporter: Keys Botzum
>            Assignee: Sorabh Hamirwasia
>              Labels: security
>         Attachments: ApacheDrillEncryptionUsingSASLDesign.pdf
>
>
> This is clearly related to Drill-291 but wanted to make explicit that this needs to include
network level encryption and not just authentication. This is particularly important for the
client connection to Drill which will often be sending passwords in the clear until there
is encryption.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message