drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4335) Apache Drill should support network encryption
Date Wed, 05 Apr 2017 22:20:45 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957898#comment-15957898
] 

ASF GitHub Bot commented on DRILL-4335:
---------------------------------------

Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/773#discussion_r109742481
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/AbstractServerConnection.java
---
    @@ -110,7 +130,31 @@ public void changeHandlerTo(final RequestHandler<S> handler)
{
       }
     
       @Override
    -  public void close() {
    +  public void setEncrypted(boolean encrypted){
    +    throw new UnsupportedOperationException("Changing encryption setting on server connection
is not permitted.");
    +  }
    +
    +  @Override
    +  public void setWrappedChunkSize(int chunkSize) {
    +    throw new UnsupportedOperationException("Changing WrappedChunkSize setting on server
connection is not permitted.");
    +  }
    +
    +
    +  @Override
    +  public void incConnectionCounter() {
    +    config.incConnectionCounter(isEncrypted());
    +  }
    +
    +  @Override
    +  public void decConnectionCounter() {
    +    config.decConnectionCounter(isEncrypted());
    +  }
    +
    +  @Override
    +  public void channelClosed(RpcException ex) {
    +    // This will be triggered from Netty when a channel is closed. We should cleanup
here
    --- End diff --
    
    nice catch


> Apache Drill should support network encryption
> ----------------------------------------------
>
>                 Key: DRILL-4335
>                 URL: https://issues.apache.org/jira/browse/DRILL-4335
>             Project: Apache Drill
>          Issue Type: New Feature
>            Reporter: Keys Botzum
>            Assignee: Sorabh Hamirwasia
>              Labels: security
>         Attachments: ApacheDrillEncryptionUsingSASLDesign.pdf
>
>
> This is clearly related to Drill-291 but wanted to make explicit that this needs to include
network level encryption and not just authentication. This is particularly important for the
client connection to Drill which will often be sending passwords in the clear until there
is encryption.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message