drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4335) Apache Drill should support network encryption
Date Wed, 05 Apr 2017 22:20:44 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957893#comment-15957893
] 

ASF GitHub Bot commented on DRILL-4335:
---------------------------------------

Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/773#discussion_r110021847
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/SaslProperties.java
---
    @@ -0,0 +1,72 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.rpc.security;
    +
    +import javax.security.sasl.Sasl;
    +import java.util.HashMap;
    +import java.util.Map;
    +
    +public final class SaslProperties {
    +
    +  /**
    +   * All supported Quality of Protection value which can be negotiated for
    +   */
    +  enum QualityOfProtection {
    +    AUTHENTICATION("auth"),
    +    INTEGRITY("auth-int"),
    +    PRIVACY("auth-conf");
    +
    +    public final String saslQop;
    +
    +    QualityOfProtection(String saslQop) {
    +      this.saslQop = saslQop;
    +    }
    +
    +    public String getSaslQop() {
    +      return saslQop;
    +    }
    +  }
    +
    +  static final String WRAP_RAW_SEND_SIZE = "javax.security.sasl.rawsendsize";
    +
    +  /**
    +   * Get's the map of minimum set of SaslProperties required during negotiation process
either for encryption
    +   * or authentication
    +   * @param encryptionEnabled - Flag to determine if property needed is for encryption
or authentication
    +   * @param wrappedChunkSize  - Configured wrappedChunkSize to negotiate for.
    +   *                            Default is {@link org.apache.drill.exec.rpc.RpcConstants.MAX_WRAP_SIZE}
    --- End diff --
    
    When is the value set to default?


> Apache Drill should support network encryption
> ----------------------------------------------
>
>                 Key: DRILL-4335
>                 URL: https://issues.apache.org/jira/browse/DRILL-4335
>             Project: Apache Drill
>          Issue Type: New Feature
>            Reporter: Keys Botzum
>            Assignee: Sorabh Hamirwasia
>              Labels: security
>         Attachments: ApacheDrillEncryptionUsingSASLDesign.pdf
>
>
> This is clearly related to Drill-291 but wanted to make explicit that this needs to include
network level encryption and not just authentication. This is particularly important for the
client connection to Drill which will often be sending passwords in the clear until there
is encryption.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message