Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9EA4E200C4C for ; Mon, 20 Mar 2017 16:57:47 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 9D7BE160B97; Mon, 20 Mar 2017 15:57:47 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id EF7E8160B92 for ; Mon, 20 Mar 2017 16:57:46 +0100 (CET) Received: (qmail 54988 invoked by uid 500); 20 Mar 2017 15:57:46 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 54861 invoked by uid 99); 20 Mar 2017 15:57:45 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Mar 2017 15:57:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 83D3FC0340 for ; Mon, 20 Mar 2017 15:57:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.451 X-Spam-Level: * X-Spam-Status: No, score=1.451 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id rj_IoD_1TkDe for ; Mon, 20 Mar 2017 15:57:45 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 7FFE45FBBB for ; Mon, 20 Mar 2017 15:57:44 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8541CE086E for ; Mon, 20 Mar 2017 15:57:43 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 45D8B254DF for ; Mon, 20 Mar 2017 15:57:42 +0000 (UTC) Date: Mon, 20 Mar 2017 15:57:42 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DRILL-5311) C++ connector connect doesn't check handshake result for timeout MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 20 Mar 2017 15:57:47 -0000 [ https://issues.apache.org/jira/browse/DRILL-5311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932896#comment-15932896 ] ASF GitHub Bot commented on DRILL-5311: --------------------------------------- Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/770 > C++ connector connect doesn't check handshake result for timeout > ---------------------------------------------------------------- > > Key: DRILL-5311 > URL: https://issues.apache.org/jira/browse/DRILL-5311 > Project: Apache Drill > Issue Type: Bug > Components: Client - C++ > Reporter: Laurent Goujon > Assignee: Sudheesh Katkam > Labels: ready-to-commit > Fix For: 1.11.0 > > > The C++ connector connect methods returns okay as soon as the tcp connection is succesfully established between client and server, and the handshake message is sent. However it doesn't wait for handshake to have completed. > The consequence is that if handshake failed, the error is deferred to the first query, which might be unexpected by the application. > I believe that validateHanshake method in drillClientImpl should wait for the handshake to complete, as it seems a bit more saner... -- This message was sent by Atlassian JIRA (v6.3.15#6346)