Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B7AE7200C2B for ; Thu, 2 Mar 2017 23:50:50 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id B30FE160B7D; Thu, 2 Mar 2017 22:50:50 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 07590160B6A for ; Thu, 2 Mar 2017 23:50:49 +0100 (CET) Received: (qmail 83153 invoked by uid 500); 2 Mar 2017 22:50:49 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 83143 invoked by uid 99); 2 Mar 2017 22:50:49 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Mar 2017 22:50:49 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id AC3F4C687A for ; Thu, 2 Mar 2017 22:50:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.651 X-Spam-Level: X-Spam-Status: No, score=0.651 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id sXOsm6DGpBKm for ; Thu, 2 Mar 2017 22:50:48 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 645875FCE7 for ; Thu, 2 Mar 2017 22:50:47 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 130F8E08C3 for ; Thu, 2 Mar 2017 22:50:46 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6BE2E24164 for ; Thu, 2 Mar 2017 22:50:45 +0000 (UTC) Date: Thu, 2 Mar 2017 22:50:45 +0000 (UTC) From: "Zelaine Fong (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (DRILL-5252) A condition returns always true MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 02 Mar 2017 22:50:50 -0000 [ https://issues.apache.org/jira/browse/DRILL-5252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zelaine Fong resolved DRILL-5252. --------------------------------- Resolution: Fixed Fix Version/s: 1.10.0 > A condition returns always true > ------------------------------- > > Key: DRILL-5252 > URL: https://issues.apache.org/jira/browse/DRILL-5252 > Project: Apache Drill > Issue Type: Bug > Reporter: JC > Priority: Minor > Labels: ready-to-commit > Fix For: 1.10.0 > > > I've found the following code smell in recent github snapshot. > Path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/EqualityVisitor.java > {code:java} > 287 > 288 @Override > 289 public Boolean visitNullConstant(TypedNullConstant e, LogicalExpression value) throws RuntimeException { > 290 if (!(value instanceof TypedNullConstant)) { > 291 return false; > 292 } > 293 return e.getMajorType().equals(e.getMajorType()); > 294 } > 295 > {code} > Should it be like this? > {code:java} > 292 } > 293 return value.getMajorType().equals(e.getMajorType()); > 294 } > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)