Mailing-List: contact issues-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
Date: Tue, 28 Mar 2017 20:13:41 +0000 (UTC)
From: "Paul Rogers (JIRA)" <jira@apache.org>
To: issues@drill.apache.org
Message-ID: <JIRA.13022241.1479746066000.146648.1490732021596@Atlassian.JIRA>
In-Reply-To: <JIRA.13022241.1479746066000@Atlassian.JIRA>
References: <JIRA.13022241.1479746066000@Atlassian.JIRA> <JIRA.13022241.1479746066419@jira-lw-us.apache.org>
Subject: [jira] [Commented] (DRILL-5055) External Sort does not delete spill
 file if error occurs during close
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 28 Mar 2017 20:13:45 -0000


    [ https://issues.apache.org/jira/browse/DRILL-5055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945858#comment-15945858 ] 

Paul Rogers commented on DRILL-5055:
------------------------------------

Hard to verify for QA. Verified with a unit test.

> External Sort does not delete spill file if error occurs during close
> ---------------------------------------------------------------------
>
>                 Key: DRILL-5055
>                 URL: https://issues.apache.org/jira/browse/DRILL-5055
>             Project: Apache Drill
>          Issue Type: Sub-task
>    Affects Versions: 1.8.0
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>            Priority: Minor
>             Fix For: 1.11.0
>
>
> DRILL-3898 recently fixed a case in which disk space was exhausted during a spill event for the external sort. In this case, the call to close failed because close attempted to flush remaining buffered data, but that also failed due to out of space.
> While the fix works, the fix causes the partially-completed spill file to be left on disk. Consider this code in {{BatchGroup.close( )}}
> {code}
>     if (outputStream != null) {
>       outputStream.close();
>     }
>     ...
>     if (fs != null && fs.exists(path)) {
>       fs.delete(path, false);
>     }
> {code}
> Notice that, if the output stream close fails, the spill file is not deleted. The fix is to put the delete in a finally block so that it is always deleted.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)