Mailing-List: contact issues-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
Date: Wed, 15 Mar 2017 19:37:41 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@drill.apache.org
Message-ID: <JIRA.12845953.1437157889000.30358.1489606661630@Atlassian.JIRA>
In-Reply-To: <JIRA.12845953.1437157889000@Atlassian.JIRA>
References: <JIRA.12845953.1437157889000@Atlassian.JIRA> <JIRA.12845953.1437157889771@jira-lw-us.apache.org>
Subject: [jira] [Commented] (DRILL-3510) Add ANSI_QUOTES option so that
 Drill's SQL Parser will recognize ANSI_SQL identifiers
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 15 Mar 2017 19:37:46 -0000


    [ https://issues.apache.org/jira/browse/DRILL-3510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15926826#comment-15926826 ] 

ASF GitHub Bot commented on DRILL-3510:
---------------------------------------

Github user vdiravka commented on a diff in the pull request:

    https://github.com/apache/drill/pull/520#discussion_r106263502
  
    --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaDataImpl.java ---
    @@ -184,6 +184,17 @@ private ServerMeta getServerMeta() throws SQLException {
         return serverMeta;
       }
     
    +  /**
    +   * The same as {@link DrillDatabaseMetaDataImpl#getServerMeta()} but updates server metadata for the every call
    +   * @return server meta information
    +   * @throws SQLException for error when getting server meta
    +   */
    +  private ServerMeta getUpdatedServerMeta() throws SQLException {
    --- End diff --
    
    SQL Server, for example, updates metadata in some cases
    https://www.mssqltips.com/sqlservertip/1415/determining-set-options-for-a-current-session-in-sql-server/
    Quoting_identifiers can be changes as system option. In this case any user can get the right and actual quoting_identifiers method from server_metadata.


> Add ANSI_QUOTES option so that Drill's SQL Parser will recognize ANSI_SQL identifiers 
> --------------------------------------------------------------------------------------
>
>                 Key: DRILL-3510
>                 URL: https://issues.apache.org/jira/browse/DRILL-3510
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: SQL Parser
>            Reporter: Jinfeng Ni
>            Assignee: Vitalii Diravka
>              Labels: doc-impacting
>             Fix For: 1.10.0
>
>         Attachments: DRILL-3510.patch, DRILL-3510.patch
>
>
> Currently Drill's SQL parser uses backtick as identifier quotes, the same as what MySQL does. However, this is different from ANSI SQL specification, where double quote is used as identifier quotes.  
> MySQL has an option "ANSI_QUOTES", which could be switched on/off by user. Drill should follow the same way, so that Drill users do not have to rewrite their existing queries, if their queries use double quotes. 
> {code}
> SET sql_mode='ANSI_QUOTES';
> {code}
>    


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)