drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5378) Put more information into SchemaChangeException when HashJoin hit SchemaChangeException
Date Tue, 28 Mar 2017 23:03:41 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946140#comment-15946140
] 

ASF GitHub Bot commented on DRILL-5378:
---------------------------------------

Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/801#discussion_r108558271
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/exception/SchemaChangeException.java
---
    @@ -49,4 +50,16 @@ public SchemaChangeException(String message, Object...objects){
       public SchemaChangeException(String message, Throwable cause, Object...objects){
         super(String.format(message, objects), cause);
       }
    +
    +  public static SchemaChangeException schemChanged(String message, BatchSchema priorSchema,
BatchSchema newSchema) {
    --- End diff --
    
    Nice catch.  Modified it. 


> Put more information into SchemaChangeException when HashJoin hit SchemaChangeException
> ---------------------------------------------------------------------------------------
>
>                 Key: DRILL-5378
>                 URL: https://issues.apache.org/jira/browse/DRILL-5378
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Relational Operators
>            Reporter: Jinfeng Ni
>            Assignee: Jinfeng Ni
>            Priority: Minor
>
> HashJoin currently does not allow schema change in either build side or probe side. When
HashJoin hit SchemaChangeException in the middle of execution, Drill reports a brief error
message about SchemaChangeException, without providing any information what schemas are in
the incoming batches. That makes hard to analyze the error, and understand what's going on.

> It probably makes sense to put the two differing schemas in the error message, so that
user could get better idea about the schema change. 
> Before Drill can provide support for schema change in HashJoin, the detailed error message
would help user debug error. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message