drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5355) Misc. code cleanup
Date Tue, 14 Mar 2017 22:32:41 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15925169#comment-15925169
] 

ASF GitHub Bot commented on DRILL-5355:
---------------------------------------

Github user chunhui-shi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/784#discussion_r106044402
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/PrelVisualizerVisitor.java
---
    @@ -0,0 +1,217 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.planner.physical.visitor;
    +
    +import org.apache.drill.exec.planner.physical.ExchangePrel;
    +import org.apache.drill.exec.planner.physical.JoinPrel;
    +import org.apache.drill.exec.planner.physical.Prel;
    +import org.apache.drill.exec.planner.physical.ProjectPrel;
    +import org.apache.drill.exec.planner.physical.ScanPrel;
    +import org.apache.drill.exec.planner.physical.ScreenPrel;
    +import org.apache.drill.exec.planner.physical.WriterPrel;
    +
    +/**
    + * Debug-time class that prints a PRel tree to the console for
    + * inspection. Insert this into code during development to see
    + * the state of the tree at various points of interest during
    + * the planning process.
    + */
    +
    +public class PrelVisualizerVisitor
    --- End diff --
    
    Would like to see a unit test for this class.


> Misc. code cleanup 
> -------------------
>
>                 Key: DRILL-5355
>                 URL: https://issues.apache.org/jira/browse/DRILL-5355
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.10.0
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>            Priority: Minor
>             Fix For: 1.11.0
>
>
> Recent work in Drill has identified a number of cases where code can be cleaned up: adding
missing annotations, etc. These changes don't fit as part of a separate ticket and so are
rolled up into a this "general hygiene" ticket.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message