drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5326) Unit tests failures related to the SERVER_METADTA
Date Tue, 07 Mar 2017 22:57:37 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900343#comment-15900343

ASF GitHub Bot commented on DRILL-5326:

Github user jinfengni commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/metadata/ServerMetaProvider.java
    @@ -76,7 +76,7 @@
    -      .setNullCollation(NullCollation.NC_AT_END)
    +      .setNullCollation(NullCollation.NC_HIGH)
    --- End diff --
    I'm not completely sure why we should change from NC_AT_END to NC_HIGH, in stead of NC_AT_END.
 I thought Drill is using ASC as default ordering, and NULLS LAST as default null collation
for ASC. This is consistent to what Oracle [1] and Postgres [2] is doing : ASC /NULL LAST
is the default option.  
    1. http://docs.oracle.com/javadb/
    2. https://www.postgresql.org/docs/9.4/static/queries-order.html

> Unit tests failures related to the SERVER_METADTA
> -------------------------------------------------
>                 Key: DRILL-5326
>                 URL: https://issues.apache.org/jira/browse/DRILL-5326
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Metadata
>    Affects Versions: 1.10.0
>            Reporter: Vitalii Diravka
>            Assignee: Vitalii Diravka
>            Priority: Blocker
>             Fix For: 1.10.0
> 1. In DRILL-5301 a new SERVER_META rpc call was introduced. The server will support this
method only from 1.10.0 drill version. For drill 1.10.0-SNAPHOT it is disabled. 
> When I enabled this method (by way of upgrading drill version to 1.10.0 or 1.11.0-SNAPSHOT)
I found the following exception:
> {code}
> java.lang.AssertionError: Unexpected/unhandled MinorType value GENERIC_OBJECT
> {code}
> It appears in several tests (for example in DatabaseMetadataTest#testNullsAreSortedMethodsSaySortedHigh).
> The reason of it is "GENERIC_OBJECT" RPC-/protobuf-level type is appeared in the ServerMetadata#ConvertSupportList.
(Supporting of GENERIC_OBJECT was added in DRILL-1126).
> The proposed solution is to add the appropriate "JAVA_OBJECT" sql type name for this
"GENERIC_OBJECT" RPC-/protobuf-level data type.
> 2. After fixing the first one the mentioned above test still fails by reason of the incorrect
"NullCollation" value in the "ServerMetaProvider". According to the [doc|https://drill.apache.org/docs/order-by-clause/#usage-notes]
the default val should be NC_HIGH (NULL is the highest value).

This message was sent by Atlassian JIRA

View raw message