drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5311) C++ connector connect doesn't check handshake result for timeout
Date Mon, 20 Mar 2017 15:57:42 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932896#comment-15932896
] 

ASF GitHub Bot commented on DRILL-5311:
---------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/drill/pull/770


> C++ connector connect doesn't check handshake result for timeout
> ----------------------------------------------------------------
>
>                 Key: DRILL-5311
>                 URL: https://issues.apache.org/jira/browse/DRILL-5311
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Client - C++
>            Reporter: Laurent Goujon
>            Assignee: Sudheesh Katkam
>              Labels: ready-to-commit
>             Fix For: 1.11.0
>
>
> The C++ connector connect methods returns okay as soon as the tcp connection is succesfully
established between client and server, and the handshake message is sent. However it doesn't
wait for handshake to have completed.
> The consequence is that if handshake failed, the error is deferred to the first query,
which might be unexpected by the application.
> I believe that validateHanshake method in drillClientImpl should wait for the handshake
to complete, as it seems a bit more saner...



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message