drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5311) C++ connector connect doesn't wait for handshake to complete
Date Fri, 03 Mar 2017 04:42:45 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893737#comment-15893737
] 

ASF GitHub Bot commented on DRILL-5311:
---------------------------------------

GitHub user laurentgo opened a pull request:

    https://github.com/apache/drill/pull/770

    DRILL-5311: Check handshake result in C++ connector

    In C++ client connector, DrillClientImpl::recvHandshake always
    return success, even in case of connection error (like a tcp
    timeout issue). Only on WIN32 platform would the error code be
    checked.
    
    Remove the restriction to only check on WIN32, plus add some logging.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laurentgo/drill laurent/DRILL-5311

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/770.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #770
    
----
commit 23b7ca2fc082608b4d05faf8986644dc952e5830
Author: Laurent Goujon <laurent@dremio.com>
Date:   2017-03-03T04:38:05Z

    DRILL-5311: Check handshake result in C++ connector
    
    In C++ client connector, DrillClientImpl::recvHandshake always
    return success, even in case of connection error (like a tcp
    timeout issue). Only on WIN32 platform would the error code be
    checked.
    
    Remove the restriction to only check on WIN32, plus add some logging.

----


> C++ connector connect doesn't wait for handshake to complete
> ------------------------------------------------------------
>
>                 Key: DRILL-5311
>                 URL: https://issues.apache.org/jira/browse/DRILL-5311
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Client - C++
>            Reporter: Laurent Goujon
>
> The C++ connector connect methods returns okay as soon as the tcp connection is succesfully
established between client and server, and the handshake message is sent. However it doesn't
wait for handshake to have completed.
> The consequence is that if handshake failed, the error is deferred to the first query,
which might be unexpected by the application.
> I believe that validateHanshake method in drillClientImpl should wait for the handshake
to complete, as it seems a bit more saner...



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message