drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Laurent Goujon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5311) C++ connector connect doesn't wait for handshake to complete
Date Fri, 03 Mar 2017 03:45:45 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893686#comment-15893686

Laurent Goujon commented on DRILL-5311:

you're correct, I forgot that run is a blocking operation. But I guess in that case, there's
no check about the actual completion of the handshake, and SUCCESS is always returned.

> C++ connector connect doesn't wait for handshake to complete
> ------------------------------------------------------------
>                 Key: DRILL-5311
>                 URL: https://issues.apache.org/jira/browse/DRILL-5311
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Client - C++
>            Reporter: Laurent Goujon
> The C++ connector connect methods returns okay as soon as the tcp connection is succesfully
established between client and server, and the handshake message is sent. However it doesn't
wait for handshake to have completed.
> The consequence is that if handshake failed, the error is deferred to the first query,
which might be unexpected by the application.
> I believe that validateHanshake method in drillClientImpl should wait for the handshake
to complete, as it seems a bit more saner...

This message was sent by Atlassian JIRA

View raw message