drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rahul Challapalli (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5252) A condition returns always true
Date Tue, 28 Mar 2017 22:23:41 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946077#comment-15946077
] 

Rahul Challapalli commented on DRILL-5252:
------------------------------------------

I am wondering about a possible test case which could expose this issue. Also if a filter
has an equality condition ("=") and the right side is a null constant, shouldn't drill always
return false?

> A condition returns always true
> -------------------------------
>
>                 Key: DRILL-5252
>                 URL: https://issues.apache.org/jira/browse/DRILL-5252
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: JC
>            Priority: Minor
>              Labels: ready-to-commit
>             Fix For: 1.10.0
>
>
> I've found the following code smell in recent github snapshot.
> Path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/EqualityVisitor.java
> {code:java}
> 287 
> 288   @Override
> 289   public Boolean visitNullConstant(TypedNullConstant e, LogicalExpression value)
throws RuntimeException {
> 290     if (!(value instanceof TypedNullConstant)) {
> 291       return false;
> 292     }
> 293     return e.getMajorType().equals(e.getMajorType());
> 294   }
> 295
> {code}
> Should it be like this?
> {code:java}
> 292     }
> 293     return value.getMajorType().equals(e.getMajorType());
> 294   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message