drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5089) Skip initializing all enabled storage plugins for every query
Date Sun, 26 Mar 2017 05:46:43 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15942162#comment-15942162
] 

ASF GitHub Bot commented on DRILL-5089:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/795#discussion_r108050603
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java
---
    @@ -107,26 +110,51 @@ public SqlConverter(QueryContext context) {
         this.sqlToRelConverterConfig = new SqlToRelConverterConfig();
         this.isInnerQuery = false;
         this.typeFactory = new JavaTypeFactoryImpl(DRILL_TYPE_SYSTEM);
    -    this.defaultSchema =  context.getNewDefaultSchema();
    -    this.rootSchema = rootSchema(defaultSchema);
    +
    +    this.defaultSchema = context.getPartialDefaultSchema();
    --- End diff --
    
    All these "this." prefixes are not needed. "this." is used only when member names are
the same as argument names:
    
    ```
    public Foo(String name) {
        this.name = name;
    }
    ```
    
    In this case, a reader has to double check: what is the difference between `this.defaultSchema`
and `defaultSchema`? Turns out, they are the same, so we should use the same form of reference
everywhere in the ctor.


> Skip initializing all enabled storage plugins for every query
> -------------------------------------------------------------
>
>                 Key: DRILL-5089
>                 URL: https://issues.apache.org/jira/browse/DRILL-5089
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Query Planning & Optimization
>    Affects Versions: 1.9.0
>            Reporter: Abhishek Girish
>            Assignee: Chunhui Shi
>            Priority: Critical
>
> In a query's lifecycle, at attempt is made to initialize each enabled storage plugin,
while building the schema tree. This is done regardless of the actual plugins involved within
a query. 
> Sometimes, when one or more of the enabled storage plugins have issues - either due to
misconfiguration or the underlying datasource being slow or being down, the overall query
time taken increases drastically. Most likely due the attempt being made to register schemas
from a faulty plugin.
> For example, when a jdbc plugin is configured with SQL Server, and at one point the underlying
SQL Server db goes down, any Drill query starting to execute at that point and beyond begin
to slow down drastically. 
> We must skip registering unrelated schemas (& workspaces) for a query. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message