Mailing-List: contact issues-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
Date: Sat, 18 Feb 2017 02:02:44 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@drill.apache.org
Message-ID: <JIRA.13042365.1486882470000.1772.1487383364410@Atlassian.JIRA>
In-Reply-To: <JIRA.13042365.1486882470000@Atlassian.JIRA>
References: <JIRA.13042365.1486882470000@Atlassian.JIRA> <JIRA.13042365.1486882470472@jira-lw-us.apache.org>
Subject: [jira] [Commented] (DRILL-5259) Allow listing a user-defined number
 of profiles
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sat, 18 Feb 2017 02:02:52 -0000


    [ https://issues.apache.org/jira/browse/DRILL-5259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872888#comment-15872888 ] 

ASF GitHub Bot commented on DRILL-5259:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/751#discussion_r101880246
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java ---
    @@ -220,7 +225,21 @@ public QProfiles getProfilesJSON() {
     
           final List<ProfileInfo> finishedQueries = Lists.newArrayList();
     
    -      final Iterator<Map.Entry<String, QueryProfile>> range = completed.getRange(0, MAX_PROFILES);
    +      //Defining #Profiles to load
    +      int maxProfilesToLoad;
    +      if (MaxProfiles == null) {
    +        MaxProfiles = work.getContext().getConfig().getInt(ExecConstants.HTTP_MAX_PROFILES);
    --- End diff --
    
    Just
    
    {code}
    int maxProfilesToLoad = work.getContext()...;
    {code}


> Allow listing a user-defined number of profiles 
> ------------------------------------------------
>
>                 Key: DRILL-5259
>                 URL: https://issues.apache.org/jira/browse/DRILL-5259
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Web Server
>    Affects Versions: 1.9.0
>            Reporter: Kunal Khatua
>            Assignee: Kunal Khatua
>            Priority: Trivial
>             Fix For: 1.10.0
>
>
> Currently, the web UI only lists the last 100 profiles. 
> This count is currently hard coded. The proposed change would be to create an option in drill-override.conf to provide a flexible default value, and also an option within the UI (via optional parameter in the path). 


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)