Mailing-List: contact issues-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
Date: Mon, 6 Feb 2017 17:00:42 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@drill.apache.org
Message-ID: <JIRA.12845953.1437157889000.7176.1486400442838@Atlassian.JIRA>
In-Reply-To: <JIRA.12845953.1437157889000@Atlassian.JIRA>
References: <JIRA.12845953.1437157889000@Atlassian.JIRA> <JIRA.12845953.1437157889771@jira-lw-us.apache.org>
Subject: [jira] [Commented] (DRILL-3510) Add ANSI_QUOTES option so that
 Drill's SQL Parser will recognize ANSI_SQL identifiers
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 06 Feb 2017 17:00:48 -0000


    [ https://issues.apache.org/jira/browse/DRILL-3510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15854357#comment-15854357 ] 

ASF GitHub Bot commented on DRILL-3510:
---------------------------------------

Github user vdiravka commented on a diff in the pull request:

    https://github.com/apache/drill/pull/520#discussion_r99624485
  
    --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java ---
    @@ -760,6 +765,24 @@ public void abort(Executor executor) throws SQLException {
         }
       }
     
    +  @Override
    +  public boolean useAnsiQuotedIdentifiers() throws SQLException {
    +    boolean systemOption = false;
    +    Boolean sessionOption = null;
    +    String sql = String.format("select type, bool_val from sys.options where name = '%s'",
    +        PlannerSettings.ANSI_QUOTES_KEY);
    +    ResultSet rs = executeSql(sql);
    --- End diff --
    
    Done.
    New RPC request is implemented. RPC response returns `ServerProperties` that represent the list of server session options.


> Add ANSI_QUOTES option so that Drill's SQL Parser will recognize ANSI_SQL identifiers 
> --------------------------------------------------------------------------------------
>
>                 Key: DRILL-3510
>                 URL: https://issues.apache.org/jira/browse/DRILL-3510
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: SQL Parser
>            Reporter: Jinfeng Ni
>            Assignee: Vitalii Diravka
>             Fix For: Future
>
>         Attachments: DRILL-3510.patch, DRILL-3510.patch
>
>
> Currently Drill's SQL parser uses backtick as identifier quotes, the same as what MySQL does. However, this is different from ANSI SQL specification, where double quote is used as identifier quotes.  
> MySQL has an option "ANSI_QUOTES", which could be switched on/off by user. Drill should follow the same way, so that Drill users do not have to rewrite their existing queries, if their queries use double quotes. 
> {code}
> SET sql_mode='ANSI_QUOTES';
> {code}
>    


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)