drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5257) Provide option to save query profiles sync, async or not at all
Date Wed, 22 Feb 2017 03:53:44 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15877429#comment-15877429
] 

ASF GitHub Bot commented on DRILL-5257:
---------------------------------------

Github user ppadma commented on a diff in the pull request:

    https://github.com/apache/drill/pull/747#discussion_r102378651
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
    @@ -413,4 +413,15 @@
     
       String DYNAMIC_UDF_SUPPORT_ENABLED = "exec.udf.enable_dynamic_support";
       BooleanValidator DYNAMIC_UDF_SUPPORT_ENABLED_VALIDATOR = new BooleanValidator(DYNAMIC_UDF_SUPPORT_ENABLED,
true, true);
    +
    +  /**
    +   * Option to save query profiles. If false, no query profile will be saved
    +   * for any query.
    +   */
    +  String ENABLE_QUERY_PROFILE_OPTION = "exec.query_profile.enable";
    --- End diff --
    
    After reading your comment, it feels like exec.query_profile.save would be a better choice.



> Provide option to save query profiles sync, async or not at all
> ---------------------------------------------------------------
>
>                 Key: DRILL-5257
>                 URL: https://issues.apache.org/jira/browse/DRILL-5257
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.10
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>            Priority: Minor
>             Fix For: 1.10
>
>
> DRILL-5123 improved perceived query performance by writing the query profile after sending
a final response to the client. This is the desired behaviors in most situations. However,
some tests want to verify certain results by reading the query profile from disk. Doing so
works best when the query profile is written before returning the final query results.
> This ticket requests that the timing if the query profile writing be configurable.
> * Sync: write profile before final client response.
> * Async: write profile after final client response. (Default)
> * None: don't write query profile at all
> A config option (boot time? run time?) should control the option. A boot-time option
is fine for testing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message