drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5240) Parquet reader creates unnecessary objects when checking for nullability in var length columns
Date Fri, 03 Feb 2017 18:58:51 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15851946#comment-15851946
] 

ASF GitHub Bot commented on DRILL-5240:
---------------------------------------

GitHub user parthchandra opened a pull request:

    https://github.com/apache/drill/pull/740

    DRILL-5240: Parquet - fix unnecessary object creation while checking …

    …for null values in nullable var length columns

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/parthchandra/drill DRILL-5240

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/740.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #740
    
----
commit d6c65ac7e8b5ff968e23e93ee695467165d0e3bf
Author: Parth Chandra <pchandra@maprtech.com>
Date:   2017-02-02T04:14:52Z

    DRILL-5240: Parquet - fix unnecessary object creation while checking for null values in
nullable var length columns

----


> Parquet reader creates unnecessary objects when checking for nullability in var length
columns
> ----------------------------------------------------------------------------------------------
>
>                 Key: DRILL-5240
>                 URL: https://issues.apache.org/jira/browse/DRILL-5240
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Storage - Parquet
>            Reporter: Parth Chandra
>            Assignee: Parth Chandra
>
> In {{NullableVarLengthValuesColumn.java}} we have the following line of code:
> {code}
> currentValNull = variableWidthVector.getAccessor().getObject(valuesReadInCurrentPass)
== null;
> {code}
> which creates an object to check nullability of every (nullable var char) value being
read. This object creation is expensive and can be replaced with a simple check for the null
bit.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message