drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5221) cancel message is delayed until queryid or data is received
Date Tue, 28 Feb 2017 01:30:45 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15887012#comment-15887012
] 

ASF GitHub Bot commented on DRILL-5221:
---------------------------------------

Github user vkorukanti commented on the issue:

    https://github.com/apache/drill/pull/733
  
    LGTM, +1. We may end up sending CANCEL twice to server, but the server already has state
management, so should be fine.


> cancel message is delayed until queryid or data is received
> -----------------------------------------------------------
>
>                 Key: DRILL-5221
>                 URL: https://issues.apache.org/jira/browse/DRILL-5221
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Client - C++
>    Affects Versions: 1.9.0
>            Reporter: Laurent Goujon
>            Assignee: Laurent Goujon
>
> When user is calling the cancel method of the C++ client, the client wait for a message
from the server to reply back with a cancellation message.
> In case of queries taking a long time to return batch results, it means cancellation
won't be effective until the next batch is received, instead of cancelling right away the
query (assuming the query id has already been received, which is generally the case).
> It seems this was foreseen by [~vkorukanti] in his initial patch (https://github.com/vkorukanti/drill/commit/e0ef6349aac48de5828b6d725c2cf013905d18eb)
but was omitted when I backported it post metadata changes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message