drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5208) Finding path to java executable should be deterministic
Date Sun, 26 Feb 2017 17:38:46 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15884829#comment-15884829
] 

ASF GitHub Bot commented on DRILL-5208:
---------------------------------------

Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/763#discussion_r103110976
  
    --- Diff: distribution/src/resources/drill-config.sh ---
    @@ -359,6 +366,7 @@ if [ -z "$JAVA_HOME" ]; then
           [[ $SOURCE != /* ]] && SOURCE="$DIR/$SOURCE"
         done
         JAVA_HOME="$( cd -P "$( dirname "$SOURCE" )" && cd .. && pwd )"
    +    JAVA = $SOURCE/$JAVA_BIN
    --- End diff --
    
    $SOURCE already includes bin/java, so concatenating with $JAVA_BIN will give you:
    `/usr/lib/jvm/java-1.8.0-openjdk-1.8.0.111-1.b15.el7_2.x86_64/jre/bin/java/java`.
    I guess you should concatenate $JAVA_BIN to $SOURCE dirname.


> Finding path to java executable should be deterministic
> -------------------------------------------------------
>
>                 Key: DRILL-5208
>                 URL: https://issues.apache.org/jira/browse/DRILL-5208
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Tools, Build & Test
>    Affects Versions: 1.10.0
>            Reporter: Krystal
>            Assignee: Paul Rogers
>            Priority: Minor
>
> Command to find JAVA in drill-config.sh is not deterministic.  drill-config.sh uses the
following command to find JAVA:
> JAVA=`find -L "$JAVA_HOME" -name $JAVA_BIN -type f | head -n 1`
> On one of my node the following command returned 2 entries:
> find -L $JAVA_HOME -name java -type f
> /usr/local/java/jdk1.7.0_67/jre/bin/java
> /usr/local/java/jdk1.7.0_67/bin/java
> On another node, the same command returned entries in different order:
> find -L $JAVA_HOME -name java -type f
> /usr/local/java/jdk1.7.0_67/bin/java
> /usr/local/java/jdk1.7.0_67/jre/bin/java
> The complete command picks the first one returned which may not be the same on each node:
> find -L $JAVA_HOME -name java -type f | head -n 1
> /usr/local/java/jdk1.7.0_67/jre/bin/java
> If JAVA_HOME is found, we should just append the "bin/java" to the path"
> JAVA=$JAVA_HOME/bin/java



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message