drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5208) Finding path to java executable should be deterministic
Date Fri, 24 Feb 2017 22:54:44 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15883681#comment-15883681
] 

ASF GitHub Bot commented on DRILL-5208:
---------------------------------------

GitHub user paul-rogers opened a pull request:

    https://github.com/apache/drill/pull/763

    DRILL-5208: Finding path to java executable should be deterministic

    See DRILL-5208 for background. Instead of using “find” to locate the
    java command, we use the any information available, resorting to find
    only if the “usual suspects” fails. The result is that we use the JDK
    java when available, instead of randomly choosing JDK or JRE java.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/paul-rogers/drill DRILL-5208

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/763.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #763
    
----
commit 19c412e9900bf5db80d4d95f9317d8f308669f4b
Author: Paul Rogers <progers@maprtech.com>
Date:   2017-02-24T22:53:23Z

    DRILL-5208: Finding path to java executable should be deterministic
    
    See DRILL-5208 for background. Instead of using “find” to locate the
    java command, we use the any information available, resorting to find
    only if the “usual suspects” fails. The result is that we use the JDK
    java when available, instead of randomly choosing JDK or JRE java.

----


> Finding path to java executable should be deterministic
> -------------------------------------------------------
>
>                 Key: DRILL-5208
>                 URL: https://issues.apache.org/jira/browse/DRILL-5208
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Tools, Build & Test
>    Affects Versions: 1.10.0
>            Reporter: Krystal
>            Assignee: Paul Rogers
>            Priority: Minor
>
> Command to find JAVA in drill-config.sh is not deterministic.  drill-config.sh uses the
following command to find JAVA:
> JAVA=`find -L "$JAVA_HOME" -name $JAVA_BIN -type f | head -n 1`
> On one of my node the following command returned 2 entries:
> find -L $JAVA_HOME -name java -type f
> /usr/local/java/jdk1.7.0_67/jre/bin/java
> /usr/local/java/jdk1.7.0_67/bin/java
> On another node, the same command returned entries in different order:
> find -L $JAVA_HOME -name java -type f
> /usr/local/java/jdk1.7.0_67/bin/java
> /usr/local/java/jdk1.7.0_67/jre/bin/java
> The complete command picks the first one returned which may not be the same on each node:
> find -L $JAVA_HOME -name java -type f | head -n 1
> /usr/local/java/jdk1.7.0_67/jre/bin/java
> If JAVA_HOME is found, we should just append the "bin/java" to the path"
> JAVA=$JAVA_HOME/bin/java



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message