drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5195) Publish Operator and MajorFragment Stats in Profile page
Date Thu, 23 Feb 2017 20:16:45 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881159#comment-15881159
] 

ASF GitHub Bot commented on DRILL-5195:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/756#discussion_r102807297
  
    --- Diff: exec/java-exec/src/main/resources/rest/profile/profile.ftl ---
    @@ -107,6 +107,9 @@
       <p>FOREMAN: ${model.getProfile().getForeman().getAddress()}</p>
       <p>TOTAL FRAGMENTS: ${model.getProfile().getTotalFragments()}</p>
       <p>DURATION: ${model.getProfileDuration()}</p>
    +  <p>&nbsp;&nbsp;&nbsp;&nbsp;PLANNING: ${model.getPlanningDuration()}</p>
    +  <p>&nbsp;&nbsp;&nbsp;&nbsp;QUEUED: ${model.getQueuedDuration()}</p>
    +  <p>&nbsp;&nbsp;&nbsp;&nbsp;EXECUTION: ${model.getExecutionDuration()}</p>
    --- End diff --
    
    Thanks for the indent. But, using nbsp is old-school. Please create a style that sets
the left margin to, say 4em.
    
    Also, as long as we are here, might as well clean up the labels. Shift from UPPER CASE
to Title Case.
    
    And, for extra credit, change the whole mess to a table so that the values are all aligned
in a nice column.


> Publish Operator and MajorFragment Stats in Profile page
> --------------------------------------------------------
>
>                 Key: DRILL-5195
>                 URL: https://issues.apache.org/jira/browse/DRILL-5195
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Web Server
>    Affects Versions: 1.9.0
>            Reporter: Kunal Khatua
>            Assignee: Kunal Khatua
>         Attachments: dbit_complete.png, dbit_inflight.png, dbit_opOverview.png
>
>
> Currently, we show runtimes for major fragments, and min,max,avg times for setup, processing
and waiting for various operators.
> It would be worthwhile to have additional stats for the following:
> MajorFragment
>   %Busy - % of the active time for all the minor fragments within each major fragment
that they were busy. 
> Operator Profile
>   %Busy - % of the active time for all the fragments within each operator that they were
busy. 
>   Records - Total number of records propagated out by that operator.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message