drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5190) Display planning time for a query in its profile page
Date Mon, 13 Feb 2017 23:25:42 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864661#comment-15864661
] 

ASF GitHub Bot commented on DRILL-5190:
---------------------------------------

Github user kkhatua commented on a diff in the pull request:

    https://github.com/apache/drill/pull/738#discussion_r100925486
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java
---
    @@ -417,6 +417,9 @@ private void parseAndRunPhysicalPlan(final String json) throws ExecutionSetupExc
     
       private void runPhysicalPlan(final PhysicalPlan plan) throws ExecutionSetupException
{
         validatePlan(plan);
    +    //Marking endTime of Planning
    +    queryManager.markPlanningEndTime();
    --- End diff --
    
    Right. The method actually is multiple steps..
    1. Validate Plan
    2. SortMemAllocations
    3. Wait In Queue
    4. Setup Fragments
    5. Execute... 
    
    I wanted to explicitly provide the delta time until step 1. 
    Step 2 is not related to planning (though we can consider including it). Logically, it
is planning. 
    Step 3 is probably useful only in the RM scenario, but I cannot estimate it for older
profiles. Let's file a **separate** JIRA for this bit? It most certainly involves another
addition to the protobuf. 
    Step 4. Expected to be a low cost operation like Step 2 and not certainly related to planning.
    



> Display planning time for a query in its profile page
> -----------------------------------------------------
>
>                 Key: DRILL-5190
>                 URL: https://issues.apache.org/jira/browse/DRILL-5190
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Web Server
>    Affects Versions: 1.9.0
>            Reporter: Kunal Khatua
>            Assignee: Kunal Khatua
>
> Currently, the Web UI does not display the time spent in planning for a query in its
profile page. The estimate needs to be done by seeing how late did the earliest major fragment
start. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message