drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5190) Display planning time for a query in its profile page
Date Fri, 03 Feb 2017 22:54:51 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15852268#comment-15852268
] 

ASF GitHub Bot commented on DRILL-5190:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/738#discussion_r99439263
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
    @@ -77,12 +77,14 @@
        */
       public static String getPrettyDuration(long startTimeMillis, long endTimeMillis) {
         long durationInMillis = (startTimeMillis > endTimeMillis ? System.currentTimeMillis()
: endTimeMillis) - startTimeMillis;
    -    long hours = TimeUnit.MILLISECONDS.toHours(durationInMillis);
    +    long days = TimeUnit.MILLISECONDS.toDays(durationInMillis);
    --- End diff --
    
    Good point. Maybe have a single utility class with two methods: one for the compact form,
one for the verbose form. Callers can choose the format best for a particular presentation.
    
    Note that, in both cases, we need to tear apart the duration into various units. This
suggests not a static class, but an actual "real" class:
    ```
    DurationFormat df = new DurationFormat( durationMs );
    System.out.println( df.compact() );
    System.out.println( df.verbose() );
    ```


> Display planning time for a query in its profile page
> -----------------------------------------------------
>
>                 Key: DRILL-5190
>                 URL: https://issues.apache.org/jira/browse/DRILL-5190
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Web Server
>    Affects Versions: 1.9.0
>            Reporter: Kunal Khatua
>            Assignee: Kunal Khatua
>
> Currently, the Web UI does not display the time spent in planning for a query in its
profile page. The estimate needs to be done by seeing how late did the earliest major fragment
start. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message