drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5190) Display planning time for a query in its profile page
Date Fri, 03 Feb 2017 19:44:52 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15852012#comment-15852012

ASF GitHub Bot commented on DRILL-5190:

Github user kkhatua commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
    @@ -77,12 +77,14 @@
       public static String getPrettyDuration(long startTimeMillis, long endTimeMillis) {
         long durationInMillis = (startTimeMillis > endTimeMillis ? System.currentTimeMillis()
: endTimeMillis) - startTimeMillis;
    -    long hours = TimeUnit.MILLISECONDS.toHours(durationInMillis);
    +    long days = TimeUnit.MILLISECONDS.toDays(durationInMillis);
    --- End diff --
    @paul-rogers , The format in DRILL-5230 is compacted to an approximation (i.e. we retain
the 2 largest units of time) so as to fit within the cells of a table. 
    This format is more verbose as it gives the complete picture, down to the smallest unit
of time. Do we want to still merge the two into a single utility method?

> Display planning time for a query in its profile page
> -----------------------------------------------------
>                 Key: DRILL-5190
>                 URL: https://issues.apache.org/jira/browse/DRILL-5190
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Web Server
>    Affects Versions: 1.9.0
>            Reporter: Kunal Khatua
>            Assignee: Kunal Khatua
> Currently, the Web UI does not display the time spent in planning for a query in its
profile page. The estimate needs to be done by seeing how late did the earliest major fragment

This message was sent by Atlassian JIRA

View raw message