drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5114) Rationalize use of Logback logging in unit tests
Date Mon, 27 Feb 2017 22:34:45 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886670#comment-15886670

ASF GitHub Bot commented on DRILL-5114:

Github user paul-rogers commented on the issue:

    Can't achieve different log levels for different appenders. To favor Lilith, cannot reduce
the level for console. So, need to come up with an alternative solution. Closing again until
that is sorted out.

> Rationalize use of Logback logging in unit tests
> ------------------------------------------------
>                 Key: DRILL-5114
>                 URL: https://issues.apache.org/jira/browse/DRILL-5114
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.8.0
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>            Priority: Minor
> Drill uses Logback as its logger. The logger is used in several to display some test
output. Test output is sent to stdout, rather than a log file. Since Drill also uses Logback,
that same configuration sends much Drill logging output to stdout as well, cluttering test
> Logback requires that that one Logback config file (either logback.xml or hogback-test.xml)
exist on the class path. Tests store the config file in the src/test/resources folder of each
> These files set the default logging level to debug. While this setting is fine when working
with individual tests, the output is overwhelming for bulk test runs.
> The first requested change is to set the default logging level to error.
> The existing config files are usually called "logback.xml." Change the name of test files
to "logback-test.xml" to make clear that they are, in fact, test configs.
> The {{exec/java-exec/src/test/resources/logback.xml}} config file is a full version of
Drill's production config file. Replace this with a config suitable for testing (that is,
the same as other modules.)
> The java-exec project includes a production-like config file in its non-test sources:
{{exec/java-exec/src/main/resources/logback.xml}}. Remove this as it is not needed. (Instead,
rely on the one shipped in the distribution subsystem, which is the one copied to the Drill
> Since Logback complains bitterly (via many log messages) when it cannot find a configuration
file (and each sub-module must have its own test configuration), add missing logging configuration
> * exec/memory/base/src/test/resources/logback-test.xml
> * logical/src/test/resources/logback-test.xml

This message was sent by Atlassian JIRA

View raw message