drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4280) Kerberos Authentication
Date Wed, 15 Feb 2017 00:06:41 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15866965#comment-15866965
] 

ASF GitHub Bot commented on DRILL-4280:
---------------------------------------

Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/578#discussion_r101175920
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
    @@ -435,9 +427,14 @@ public synchronized boolean reconnect() {
       }
     
       private void connect(DrillbitEndpoint endpoint) throws RpcException {
    -    final FutureHandler f = new FutureHandler();
    -    client.connect(f, endpoint, props, getUserCredentials());
    -    f.checkedGet();
    +    client.connect(endpoint, properties, getUserCredentials()).checkedGet();
    +    if (client.serverRequiresAuthentication()) {
    +      try {
    +        client.authenticate(null).checkedGet();
    +      } catch (SaslException e) {
    +        throw new RpcException(e);
    +      }
    --- End diff --
    
    Originally if client fail's to connect to server because of Authentication failure, then
it doesn't retry since `InvalidConnectionInfoException` is thrown and handled separately.
    
    But If authentication using SASL fails then we are always throwing `RpcException` and
we will end up doing retry. We should have a check for exception thrown by SASL authentication
failure and doesn't do retry in that scenario as well.


> Kerberos Authentication
> -----------------------
>
>                 Key: DRILL-4280
>                 URL: https://issues.apache.org/jira/browse/DRILL-4280
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Keys Botzum
>            Assignee: Sudheesh Katkam
>              Labels: security
>
> Drill should support Kerberos based authentication from clients. This means that both
the ODBC and JDBC drivers as well as the web/REST interfaces should support inbound Kerberos.
For Web this would most likely be SPNEGO while for ODBC and JDBC this will be more generic
Kerberos.
> Since Hive and much of Hadoop supports Kerberos there is a potential for a lot of reuse
of ideas if not implementation.
> Note that this is related to but not the same as https://issues.apache.org/jira/browse/DRILL-3584




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message