drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4280) Kerberos Authentication
Date Fri, 03 Feb 2017 02:13:52 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15850924#comment-15850924
] 

ASF GitHub Bot commented on DRILL-4280:
---------------------------------------

Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/578#discussion_r99247679
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ConnectionManagerRegistry.java
---
    @@ -32,24 +29,19 @@
     
       private final ConcurrentMap<DrillbitEndpoint, ControlConnectionManager> registry
= Maps.newConcurrentMap();
     
    -  private final ControlMessageHandler handler;
    -  private final BootStrapContext context;
    -  private volatile DrillbitEndpoint localEndpoint;
    -  private final BufferAllocator allocator;
    +  private final BitConnectionConfigImpl config;
     
    -  public ConnectionManagerRegistry(BufferAllocator allocator, ControlMessageHandler handler,
BootStrapContext context) {
    -    super();
    -    this.handler = handler;
    -    this.context = context;
    -    this.allocator = allocator;
    +  public ConnectionManagerRegistry(BitConnectionConfigImpl config) {
    +    this.config = config;
       }
     
    -  public ControlConnectionManager getConnectionManager(DrillbitEndpoint endpoint) {
    -    assert localEndpoint != null : "DrillbitEndpoint must be set before a connection
manager can be retrieved";
    -    ControlConnectionManager m = registry.get(endpoint);
    +  public ControlConnectionManager getConnectionManager(DrillbitEndpoint remoteEndpoint)
{
    +    assert config.getLocalEndpoint() != null :
    +        "DrillbitEndpoint must be set before a connection manager can be retrieved";
    +    ControlConnectionManager m = registry.get(remoteEndpoint);
         if (m == null) {
    -      m = new ControlConnectionManager(allocator, endpoint, localEndpoint, handler, context);
    -      ControlConnectionManager m2 = registry.putIfAbsent(endpoint, m);
    +      m = new ControlConnectionManager(config, remoteEndpoint);
    +      ControlConnectionManager m2 = registry.putIfAbsent(remoteEndpoint, m);
    --- End diff --
    
    can be final.


> Kerberos Authentication
> -----------------------
>
>                 Key: DRILL-4280
>                 URL: https://issues.apache.org/jira/browse/DRILL-4280
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Keys Botzum
>            Assignee: Sudheesh Katkam
>              Labels: security
>
> Drill should support Kerberos based authentication from clients. This means that both
the ODBC and JDBC drivers as well as the web/REST interfaces should support inbound Kerberos.
For Web this would most likely be SPNEGO while for ODBC and JDBC this will be more generic
Kerberos.
> Since Hive and much of Hadoop supports Kerberos there is a potential for a lot of reuse
of ideas if not implementation.
> Note that this is related to but not the same as https://issues.apache.org/jira/browse/DRILL-3584




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message